[#] http://marc.info/?l=openbsd-cvs&m=140744081427175&w=2
openbsd-cvs(obsdave,2) — All
2014-08-07 23:55:10


Module name: src
Changes by: miod@cvs.openbsd.org 2014/08/07 13:46:31

Modified files:
lib/libssl/src/ssl: d1_both.c d1_clnt.c d1_pkt.c s23_srvr.c
s3_both.c s3_enc.c s3_lib.c t1_enc.c

Log message:
When you expect a function to return a particular value, don't put a comment
saying that you expect it to return that value and compare it against zero
because it is supposedly faster, for this leads to bugs (especially given the
high rate of sloppy cut'n'paste within ssl3 and dtls1 routines in this
library).

Instead, compare for the exact value it ought to return upon success.

ok deraadt@